autoClose breaks Lazy

[nomisRev]

Which version of Kotest are you using

1.4.6

Here Lazy is immediately invoked which initializes the Lazy value, to then pass it to the immediate autoClose function which rewraps in Lazy here.

If delegation happens to other way around, meaning fun <T : AutoCloseable> autoClose(closeable: T): T uses fun <T : AutoCloseable> autoClose(closeable: Lazy<T>): Lazy<T> than Lazy'ness can be preserved.

When closing the AutoCloseable in invokeAfterSpec you can check Lazy#isInitialised before calling lazy.value.close() to avoid initializing values that are not used, and thus don't need to be closed.

[nomisRev]

Causing following issue:

Integration tests with Docker hosted Postgres, and HikariDataSource.

i.e:

class IntegrationTest : StringSpec({
  val container = PostgressContainer().apply { ... }
  listeners(container.perSpec())
  val dataSource by autoClose(lazy { dataSource(container, ...) })
})

Since autoClose breaks Lazy it will try to initialize itself immediately which means it doesn't respect the lifecycle of container which was should be started before autoClose is used for the first time.

[nomisRev]

Happy to open a PR for this 👍

[sksamuel]

Please do !

…

On Fri, 30 Jul 2021, 02:41 Simon Vergauwen, ***@***.***> wrote: Happy to open a PR for this 👍 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#2388 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFVSGU2GJ4U43XUURY2SN3T2JJSBANCNFSM5BH7EXEA> .