Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inspectors should return the collection to allow chaining #2588

Closed
Tracked by #2226
dalewking opened this issue Oct 29, 2021 · 1 comment · Fixed by #2589
Closed
Tracked by #2226

Inspectors should return the collection to allow chaining #2588

dalewking opened this issue Oct 29, 2021 · 1 comment · Fixed by #2589
Labels
assertions 🔍 Related to the assertion mechanisms within the testing framework. enhancement ✨ Suggestions for adding new features or improving existing ones.
Milestone
5.0

Comments

@dalewking
Copy link
Contributor

Inspectors currently return Unit. it would be nice if they returned the collection they are invoked on to allow chaining inspector calls
@dalewking dalewking added the enhancement ✨ Suggestions for adding new features or improving existing ones. label Oct 29, 2021
sksamuel added a commit that referenced this issue Oct 30, 2021
@sksamuel
Inspectors should return the collection to allow chaining #2588
0b52fd4
@sksamuel sksamuel added this to the 5.0 milestone Oct 30, 2021
@sksamuel sksamuel added the assertions 🔍 Related to the assertion mechanisms within the testing framework. label Oct 30, 2021
@sksamuel sksamuel mentioned this issue Oct 30, 2021
Merged
@sksamuel
Copy link
Member

#2589

sksamuel added a commit that referenced this issue Oct 30, 2021
@sksamuel
Inspectors should return the collection to allow chaining #2588
11eba37
sksamuel added a commit that referenced this issue Oct 30, 2021
@sksamuel
Inspectors should return the collection to allow chaining #2588 (#2589)
f5ed7d0 
* Inspectors should return the collection to allow chaining #2588

* Feedback
sksamuel added a commit that referenced this issue Oct 30, 2021
@sksamuel
Feature/2588 (#2591)
5409277 
* Inspectors should return the collection to allow chaining #2588

* Feedback

* Moved compiler assertions to top level repo
@sksamuel sksamuel mentioned this issue Nov 11, 2021
Closed
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
assertions 🔍 Related to the assertion mechanisms within the testing framework. enhancement ✨ Suggestions for adding new features or improving existing ones.
Projects
None yet
Milestone
5.0
Development

Successfully merging a pull request may close this issue.

Inspectors should return the collection to allow chaining #2588 kotest/kotest
2 participants
@dalewking @sksamuel