Test fails because lhs of shouldBe is List, and rhs is a home-grown Iterable

[inquiribus]

Kotest 5.0.3

This is the continuation of this discussion started on the Kotest slack community

Summary: lsh and rhs of shouldBe for Iterable<*> should recognize, in addition to Collection and superclasses, also barebone Iterable implementations.

There is ambiguity as to how address type equality.

Presently shouldBe makes a special case for Set, which is Collection but is not universally guaranteed to be ordered (in Kotlin; Set as large has no ordering guarantee whatsoever). Other Collection subclasses in Kotlin are strictly ordered. From the slack thread:

should include whatever is feasible whilst bearing in mind that you might not want this to pass:

listOf(1,2,3) shouldBe myIterable(1,2,3) // false

[ neither this should pass ]

listOf(1,2,3) shouldBe setOf(1,2,3)  // false

The intent is, therefore, to allow

myIterable(1,2,3) shouldBe myOtherIterable(1,2,3) // true

to succeed, with as little disruption as possible to the current state of affairs, maintaining backward compatibility at large, but also introducing the privileged treatment for Set which should not test equal to other non-Set Collection

I'm preparing a pull request to address the above

[sschuberth]

Hmm. The fix for this also seems to make listOf(1, 2, 3) should containExactly(1, 2, 3) fail. Is this expected?

Edit: Scratch that, I cannot reproduce this anymore.

[inquiribus]

I just saw this. Looking.

…

On Mon, Jan 17, 2022 at 3:13 AM Sebastian Schuberth < ***@***.***> wrote: Hmm. The fix for this also seems to make listOf(1, 2, 3) should containExactly(1, 2, 3) fail. Is this expected? — Reply to this email directly, view it on GitHub <#2746 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMQS2VT2JU3K3LGFKVCMG3DUWPTWNANCNFSM5KQXFENA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[sschuberth]

Please see my edit, I don't think anymore that there's an issue.