-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-nullability gets lost with shouldBeSuccess
matcher
#2759
Milestone
Comments
Lines 20 to 23 in c64f888
The block is explicitly invoked with the not-null assertion operator ( |
sschuberth
added a commit
to oss-review-toolkit/ort
that referenced
this issue
Jan 6, 2022
Use Kotlin built-in functionality wherever possible. Note that there seems to be a nullability issue with Kotest's `shouldBeSuccess` / `shouldBeFailure` matchers, see [1]. [1]: kotest/kotest#2759 Signed-off-by: Sebastian Schuberth <sebastian.schuberth@bosch.io>
sschuberth
added a commit
to oss-review-toolkit/ort
that referenced
this issue
Jan 6, 2022
Use Kotlin built-in functionality wherever possible. Note that there seems to be a nullability issue with Kotest's `shouldBeSuccess` / `shouldBeFailure` matchers, see [1]. [1]: kotest/kotest#2759 Signed-off-by: Sebastian Schuberth <sebastian.schuberth@bosch.io>
sschuberth
added a commit
to oss-review-toolkit/ort
that referenced
this issue
Jan 7, 2022
Use Kotlin built-in functionality wherever possible. Note that there seems to be a nullability issue with Kotest's `shouldBeSuccess` / `shouldBeFailure` matchers, see [1]. [1]: kotest/kotest#2759 Signed-off-by: Sebastian Schuberth <sebastian.schuberth@bosch.io>
sschuberth
added a commit
that referenced
this issue
Jan 10, 2022
Use exactly the same (not-null) type when calling the `block` as used in the `Result`. Fixes #2759.
sschuberth
added a commit
to oss-review-toolkit/ort
that referenced
this issue
Jan 17, 2022
See [1]. This allows for some simplifications as [2] was fixed. [1]: https://kotest.io/docs/changelog.html#510-january-2022 [2]: kotest/kotest#2759 Signed-off-by: Sebastian Schuberth <sebastian.schuberth@bosch.io>
sschuberth
added a commit
to oss-review-toolkit/ort
that referenced
this issue
Jan 17, 2022
See [1]. This allows for some simplifications as [2] was fixed. [1]: https://kotest.io/docs/changelog.html#510-january-2022 [2]: kotest/kotest#2759 Signed-off-by: Sebastian Schuberth <sebastian.schuberth@bosch.io>
sschuberth
added a commit
to oss-review-toolkit/ort
that referenced
this issue
Jan 17, 2022
See [1]. This allows for some simplifications as [2] was fixed. [1]: https://kotest.io/docs/changelog.html#510-january-2022 [2]: kotest/kotest#2759 Signed-off-by: Sebastian Schuberth <sebastian.schuberth@bosch.io>
sschuberth
added a commit
to oss-review-toolkit/ort
that referenced
this issue
Jan 17, 2022
See [1] which was fixed in Kotest 5.1.0. [1]: kotest/kotest#2759 Signed-off-by: Sebastian Schuberth <sebastian.schuberth@bosch.io>
sschuberth
added a commit
to oss-review-toolkit/ort
that referenced
this issue
Jan 17, 2022
See [1] which was fixed in Kotest 5.1.0. [1]: kotest/kotest#2759 Signed-off-by: Sebastian Schuberth <sebastian.schuberth@bosch.io>
sschuberth
added a commit
to oss-review-toolkit/ort
that referenced
this issue
Jan 17, 2022
See [1] which was fixed in Kotest 5.1.0. [1]: kotest/kotest#2759 Signed-off-by: Sebastian Schuberth <sebastian.schuberth@bosch.io>
sschuberth
added a commit
to oss-review-toolkit/ort
that referenced
this issue
Jan 17, 2022
See [1] which was fixed in Kotest 5.1.0. [1]: kotest/kotest#2759 Signed-off-by: Sebastian Schuberth <sebastian.schuberth@bosch.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This looks like a bug to me:
kotest/kotest-assertions/kotest-assertions-core/src/commonMain/kotlin/io/kotest/matchers/result/matchers.kt
Line 9 in c64f888
If the result is of type
T
(non-nullable), why is the block then called with the nullable typeT?
?The text was updated successfully, but these errors were encountered: