-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better support for comparing multi-line strings #402
Labels
enhancement ✨
Suggestions for adding new features or improving existing ones.
Milestone
Comments
Closed
sksamuel
added
the
enhancement ✨
Suggestions for adding new features or improving existing ones.
label
Sep 11, 2018
sksamuel
added a commit
that referenced
this issue
Dec 2, 2018
sksamuel
added a commit
that referenced
this issue
Dec 2, 2018
I've added my attempt. You end up with a sequence of diffs. Each diff has a type (delete, change, addition), the line where it started, and the snippet that changed (with a line before/after for context). The raw exception message is like this:
Which intellij picks up nicely and shows the diff window. |
sksamuel
added a commit
that referenced
this issue
Dec 2, 2018
sksamuel
added a commit
that referenced
this issue
Dec 2, 2018
sksamuel
added a commit
that referenced
this issue
Dec 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When doing
where both
actualResult
andexpectedResult
are (long) multi-line strings, console output in case of a mismatch could be improved. Currently, as can be seen e.g. here, console output starts with the expected text. However, as that text is long and console output is limited, it does not even come as far as also showing the actual output. To address this, it would be nice if long multi-line output was condensed by stripping matching lines, and only keeping "diff hunks" similar like Git does to display only the areas of text where there actually is a difference.The text was updated successfully, but these errors were encountered: