Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "condensed" multi-line diffs configurable #607

Closed
sschuberth opened this issue Jan 24, 2019 · 4 comments
Closed

Make "condensed" multi-line diffs configurable #607

sschuberth opened this issue Jan 24, 2019 · 4 comments
Labels
enhancement ✨ Suggestions for adding new features or improving existing ones.
Milestone

Comments

@sschuberth
Copy link
Member

While it's nice that #402 was implemented, there are cases where we'd like to turn off that feature, e.g. to accept actual results as the new expected results. Can we maybe have a system property that toggles the "condensed" multi-line diff, turning it off by default for backwards compatibility with most past releases?

@sksamuel
Copy link
Member

@kerooker lets add this along with the bang fix, and make that 3.2.2

@LeoColman
Copy link
Member

@sksamuel Should we include the other non-breaking minor changes as well?

@sksamuel
Copy link
Member

Which one was that again.

@LeoColman
Copy link
Member

LeoColman commented Jan 29, 2019

All PRs with an exception of Contracts, and commits to master that you made (I'll have to look at them to see if any implementation changed):

#506 #603 #606 #608 #609

And maybe
#543 and #613 if they're ready with this one

These are all the PRS created/merged after 3.2.1 was released

@LeoColman LeoColman added the enhancement ✨ Suggestions for adding new features or improving existing ones. label Jan 29, 2019
@sksamuel sksamuel modified the milestones: 3.3, 3.4, 3.2 Feb 13, 2019
@sksamuel sksamuel mentioned this issue Feb 13, 2019
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ Suggestions for adding new features or improving existing ones.
Projects
None yet
Development

No branches or pull requests

3 participants