beforeProject / afterProject in TestListener is confusing

[sksamuel]

These methods won't be invoked in a test listener, so they should be in some kind of project listener.

[alladywek]

small example:

class A : StringSpec() {

    override fun listeners(): List<TestListener> = listOf(object : TestListener {
        override fun beforeProject() {
            println("before project")
        }

        override fun afterProject() {
            println("after project")
        }
    })

    init {
        "test1" {
            println("test")
        }
    }
}

// will print:
// test

[LeoColman]

I removed the bug label, I don't think this is a bug.

It's confusing tho xD

[LeoColman]

How to deprecate this without breaking client code?

Currently, any user is implementing project listeners using the TestListener.

[sksamuel]

Maybe just deprecate it from TestListener and then add a new ProjectListener.

…

On Tue, 25 Jun 2019, 13:24 Leonardo Colman Lopes, ***@***.***> wrote: How to deprecate this without breaking client code? Currently, any user is implementing project listeners using the TestListener. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#859>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAFVSGX2FJNOJPPUK5QHWDDP4JPEVANCNFSM4H2XPGIQ> .

[sksamuel]

Added ProjectListener