-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lack of LocalTime assertions #889
Comments
What kind of assertions do you suggest for LocalTime?
Em seg, 15 de jul de 2019 08:14, Abbas Abbasov <notifications@github.com>
escreveu:
… I faced with problem that kotlintest doesn't have assertions for LocalTime
class
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#889>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAMBCIZUYJL4LMI4HGAMS53P7RL3BANCNFSM4IDVWGCA>
.
|
and their versions with |
Great matchers!
Do you want to do it? We are open to prs!
If you are not, no worries, we can take it from here
Em seg, 15 de jul de 2019 10:10, Abbas Abbasov <notifications@github.com>
escreveu:
… LocalTime.shouldBeAfter(LocalTime)
LocalTime.shouldBeBefore(LocalTime)
LocalTime.shouldBeBetween(LocalTime)
LocalTime.shouldHaveSameSecondsAs(LocalTime)
LocalTime.shouldHaveSameHoursAs(LocalTime)
LocalTime.shouldHaveSameMinutesAs(LocalTime)
LocalTime.shouldHaveSameNanosAs(LocalTime)
and their versions with Not, they are the similar as from
io.kotlintest.matchers.date
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#889>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAMBCI2U5Z74HU6NGNNNG4DP7RZKXANCNFSM4IDVWGCA>
.
|
I can do it |
We could add this to 3.4 if it's ready in the next couple of days ! |
I think I will do it today/tomorrow |
When you do this @alladywek can you add them in a seperate file |
yeah, I saw your message after PR =) I will change it. |
I faced with problem that kotlintest doesn't have assertions for LocalTime class
The text was updated successfully, but these errors were encountered: