Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of LocalTime assertions #889

Closed
alladywek opened this issue Jul 15, 2019 · 8 comments
Closed

Lack of LocalTime assertions #889

alladywek opened this issue Jul 15, 2019 · 8 comments
Labels
enhancement ✨ Suggestions for adding new features or improving existing ones.
Milestone

Comments

@alladywek
Copy link
Contributor

I faced with problem that kotlintest doesn't have assertions for LocalTime class

@LeoColman
Copy link
Member

LeoColman commented Jul 15, 2019 via email

@alladywek
Copy link
Contributor Author

LocalTime.shouldBeAfter(LocalTime)
LocalTime.shouldBeBefore(LocalTime)
LocalTime.shouldBeBetween(LocalTime)
LocalTime.shouldHaveSameSecondsAs(LocalTime)
LocalTime.shouldHaveSameHoursAs(LocalTime)
LocalTime.shouldHaveSameMinutesAs(LocalTime)
LocalTime.shouldHaveSameNanosAs(LocalTime)

and their versions with Not, they are the similar as from io.kotlintest.matchers.date

@LeoColman
Copy link
Member

LeoColman commented Jul 15, 2019 via email

@alladywek
Copy link
Contributor Author

I can do it

@sksamuel
Copy link
Member

We could add this to 3.4 if it's ready in the next couple of days !

@sksamuel sksamuel added this to the 3.4 milestone Jul 15, 2019
@sksamuel sksamuel added the enhancement ✨ Suggestions for adding new features or improving existing ones. label Jul 15, 2019
@sksamuel sksamuel mentioned this issue Jul 15, 2019
39 tasks
@alladywek
Copy link
Contributor Author

We could add this to 3.4 if it's ready in the next couple of days !

I think I will do it today/tomorrow

@sksamuel
Copy link
Member

When you do this @alladywek can you add them in a seperate file localtime.kt inside the date folder. Thanks.

alladywek added a commit to alladywek/kotlintest that referenced this issue Jul 15, 2019
@alladywek
Copy link
Contributor Author

When you do this @alladywek can you add them in a seperate file localtime.kt inside the date folder. Thanks.

yeah, I saw your message after PR =) I will change it.

alladywek added a commit to alladywek/kotlintest that referenced this issue Jul 16, 2019
sksamuel pushed a commit that referenced this issue Jul 16, 2019
* (#889) add LocalTime asserts

* (#889) move LocalTime asserts to localtime.kt file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ Suggestions for adding new features or improving existing ones.
Projects
None yet
Development

No branches or pull requests

3 participants