Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shouldBe doesn't support ByteArray #913

Closed
sksamuel opened this issue Jul 22, 2019 · 8 comments · Fixed by #916
Closed

shouldBe doesn't support ByteArray #913

sksamuel opened this issue Jul 22, 2019 · 8 comments · Fixed by #916
Labels
bug 🐛 Issues that report a problem or error in the code. good-first-issue 👶 Suitable for newcomers looking to contribute to the project.

Comments

@sksamuel
Copy link
Member

It might not support other primitive array types either.

@sksamuel sksamuel added the bug 🐛 Issues that report a problem or error in the code. label Jul 22, 2019
@LeoColman LeoColman added the good-first-issue 👶 Suitable for newcomers looking to contribute to the project. label Jul 22, 2019
@LeoColman
Copy link
Member

Ok, so here's the thing:

shouldBe works correctly, but shouldNotBe doesn't.
They're not exact opposites

@LeoColman
Copy link
Member

I'm working on a fix

@sksamuel
Copy link
Member Author

sksamuel commented Jul 23, 2019 via email

@LeoColman
Copy link
Member

Hmm.. I just tested shouldBe, it is comparing ByteArray correctly

@sksamuel
Copy link
Member Author

sksamuel commented Jul 23, 2019 via email

@LeoColman
Copy link
Member

There aresomething to fix in these guys tho

@LeoColman
Copy link
Member

Their string representation doesn't have all cases, and shouldNotBe doesn't work for these primitives arrays either

@sksamuel
Copy link
Member Author

sksamuel commented Jul 23, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Issues that report a problem or error in the code. good-first-issue 👶 Suitable for newcomers looking to contribute to the project.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants