Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add infix modifier to arrow matchers #921

Closed
Jiehong opened this issue Jul 25, 2019 · 2 comments
Closed

Add infix modifier to arrow matchers #921

Jiehong opened this issue Jul 25, 2019 · 2 comments
Labels
enhancement ✨ Suggestions for adding new features or improving existing ones.

Comments

@Jiehong
Copy link
Contributor

Jiehong commented Jul 25, 2019

Hello,

It would be nice to be able to use arrow matchers just like the rest of matchers in kotlintests. For example:

val x = Either.left("value")
x shouldBeLeft "expected"

instead of:

val x = Either.left("value")
x.shouldBeLeft("expected")

But this isn't possible due to the missing infix modifier on Arrow matchers.
@LeoColman LeoColman added the enhancement ✨ Suggestions for adding new features or improving existing ones. label Jul 25, 2019
@LeoColman
Copy link
Member

Agreed!
Do you want to do it?

@sksamuel sksamuel changed the title dd infix modifier to arrow matchers Add infix modifier to arrow matchers Jul 27, 2019
Jiehong added a commit to Jiehong/kotlintest that referenced this issue Jul 31, 2019
@Jiehong
Add infix modifier to more Arrow matchers (kotest#921)
a7d941d
@Jiehong Jiehong mentioned this issue Jul 31, 2019
Merged
Jiehong added a commit to Jiehong/kotlintest that referenced this issue Aug 1, 2019
@Jiehong
Add infix modifier to more Arrow matchers (kotest#921)
24dad39
sksamuel pushed a commit that referenced this issue Aug 5, 2019
@Jiehong @sksamuel
Add infix modifier to more Arrow matchers (#921) (#931)
3943e3e
@faogustavo
Copy link
Contributor

@sksamuel I think we can close this one now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement ✨ Suggestions for adding new features or improving existing ones.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Jiehong @LeoColman @faogustavo