-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add matchers to Klock. #1214
Add matchers to Klock. #1214
Conversation
@sksamuel I have created this draft. I wanted to get an opinion on the approach I have used. Also, what are the matchers that should be implemented. |
I believe you're on the right track. I'm not sure if you're using our current datetime matchers as inspiration, but that can be a good starting point if you feel lost! I believe you are doing things that way already tho |
@Kerooker I think I have added all the required matchers. I haven't documented the matchers like done in existing code since, I didnt find any need for doing it, as its self documenting. But if you want me to add docs, then I can. |
kotest-assertions/kotest-assertions-klock/src/commonMain/kotlin/io.kotest/matchers/date/date.kt
Outdated
Show resolved
Hide resolved
kotest-assertions/kotest-assertions-klock/src/commonMain/kotlin/io.kotest/matchers/date/date.kt
Outdated
Show resolved
Hide resolved
kotest-assertions/kotest-assertions-klock/src/commonMain/kotlin/io.kotest/matchers/date/date.kt
Outdated
Show resolved
Hide resolved
kotest-assertions/kotest-assertions-klock/src/commonMain/kotlin/io.kotest/matchers/date/time.kt
Outdated
Show resolved
Hide resolved
If you can address the feedback @dragneelfps I will merge. This will be an excellent addition. |
@sksamuel feedback taken and code changes done. |
Build failing with:
Any help? |
The build was changed over the weekend so publish.gradle doesn't exist. That's ok, we can merge. |
Related to #1156.