Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add matchers for ResultSet. #1221

Merged
merged 4 commits into from
Feb 19, 2020
Merged

Add matchers for ResultSet. #1221

merged 4 commits into from
Feb 19, 2020

Conversation

dragneelfps
Copy link
Contributor

Contains java.sql.ResultSet assertion matchers

Inspired from #961

sksamuel
sksamuel approved these changes Feb 18, 2020
View reviewed changes
Copy link
Member

@sksamuel sksamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. We could also add one that checks for the presence of a row based on a lamda.

@dragneelfps
Copy link
Contributor Author

Looks great. We could also add one that checks for the presence of a row based on a lamda.

That will be interesting. Will add it

@dragneelfps
Copy link
Contributor Author

@sksamuel I have added the row assertion. Also, I changed the column value assertion to use generics which enables us to have different specific types in the lambda block of the assertion.

@sksamuel
Copy link
Member

Excellent.

@sksamuel sksamuel merged commit 53b3805 into kotest:master Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sksamuel sksamuel sksamuel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dragneelfps @sksamuel