Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Exhaustive.merge for two gens with a common supertype. #1502

Merged
merged 2 commits into from
Jun 7, 2020

Conversation

Octogonapus
Copy link
Contributor

Description of the Change

This PR implements the example code from #1497 for merging two Exhaustive gens with a common supertype.

Applicable Issues

Closes #1497.

@sksamuel
Copy link
Member

sksamuel commented Jun 7, 2020

That was quick.

@sksamuel
Copy link
Member

sksamuel commented Jun 7, 2020

Would you mind adding a simple unit test.

@Octogonapus
Copy link
Contributor Author

Would you mind adding a simple unit test.

I can do that. Where should I put it?

@sksamuel
Copy link
Member

sksamuel commented Jun 7, 2020 via email

@Octogonapus
Copy link
Contributor Author

Done. I had to remove the other merge declaration because the JVM signatures clashed. The new one is backward-compatible.

@Octogonapus
Copy link
Contributor Author

It looks like the ubuntu failure is not specific to my changes; it's happening on other PRs as well.

@sksamuel sksamuel merged commit 9e9ff4f into kotest:master Jun 7, 2020
@Octogonapus Octogonapus deleted the feature/1497 branch June 7, 2020 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge to an Exhausive of a superclass
2 participants