tempdir: Delete temporary directories recursively #2227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sksamuel can this still make it into the 4.5.0 release? |
|
Seems low risk so yes.
…On Mon, 26 Apr 2021, 06:09 Sebastian Schuberth, ***@***.***> wrote:
@sksamuel <https://github.com/sksamuel> can this still make it into the
4.5.0 release?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2227 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFVSGS55AWIMZP53XHG6STTKVCYHANCNFSM43SVB4OQ>
.
|
|
Can we get a test |
Previously, the logic to use javaClass.name as the default prefix could have been bypassed by setting the prefix to null. Avoid that by making javaClass.name the fallback if the prefix is null. This is a fixup for 5e78d68. Also align the temp{dir,file} functions to both use the new API functions kotlin.io.path.createTemp{Directory,File}, and avoid a duplicate toFile() conversion.
While delete() works on directories, they must be empty for delete() to succeed. However, temporary directories should be deleted recursively, including any contained files and / or subdirectories.
sschuberth
force-pushed
the
tempdir-delete-recursively
branch
from
344e97e
to
105ca10
Compare
Sorry, I didn't have time until now, but I've adapted the existing test now accordingly. and also added another improvement commit. |
|
@sksamuel I don't think the test failure on Ubuntu is related to my changes... |
|
Yeah it's not, lgtm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While delete() works on directories, they must be empty for delete() to
succeed. However, temporary directories should be deleted recursively,
including any contained files and / or subdirectories.