Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add overall project timeout #2273

Merged
merged 6 commits into from
Jul 16, 2021
Merged

add overall project timeout #2273

merged 6 commits into from
Jul 16, 2021

Conversation

jschneidereit
Copy link
Member

@jschneidereit jschneidereit commented May 22, 2021 •
edited
Loading

Fixes #2240

@jschneidereit
Copy link
Member Author

Here's an example in the gradle build scan of the project timeout in action.

sksamuel
sksamuel reviewed May 22, 2021
View reviewed changes
Copy link
Member

@sksamuel sksamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be supported by a system property too.
And you need to add support for merging the configs, adding it to the config detect is not enough.
Finally, we need a test - probably instantiate an engine, set the property and make sure it fails.

@jschneidereit jschneidereit force-pushed the feature/jschneidereit/2240-overall-project-timeout branch from 2ff9a40 to 729d32a Compare May 26, 2021 03:18
@sksamuel sksamuel force-pushed the feature/jschneidereit/2240-overall-project-timeout branch from 8c0a073 to d0c322e Compare July 16, 2021 12:56
@sksamuel sksamuel merged commit 0112dc7 into master Jul 16, 2021
@sksamuel sksamuel deleted the feature/jschneidereit/2240-overall-project-timeout branch July 16, 2021 14:31
sksamuel added a commit that referenced this pull request Jul 17, 2021
@jschneidereit @sksamuel
add overall project timeout (#2273)
b219124 
* add overall project timeout

* add proper test and sysprop config

* move timeout into submitAll

* Fix tests for project timeouts

* Fixed test

* Fixed tests

Co-authored-by: sksamuel <sam@sksamuel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sksamuel sksamuel sksamuel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ProjectConfig should support an overall suite timeout
2 participants
@jschneidereit @sksamuel