Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Arb.ints zero inclusive variants #2294

Merged
merged 1 commit into from
May 27, 2021
Merged

Add Arb.ints zero inclusive variants #2294

merged 1 commit into from
May 27, 2021

Conversation

BartvHelvert
Copy link
Contributor

This PR:

  • Adds Arb.nonPositive with matcher
  • Adds Arb.nonNegative with matcher
  • Deprecates Arb.nats

@sksamuel
Copy link
Member

Looks good .
Tests red currently.

@BartvHelvert
Add Arb.ints zero inclusive variants
68378b7 
Also deprecates Arb.nats. Closes kotest#2292.
@BartvHelvert
Copy link
Contributor Author

Looks good .
Tests red currently.

Seems like an issue caused by 4f20f38?

@sksamuel
Copy link
Member

Yep you're right, unrelated.

@sksamuel sksamuel merged commit 4014ba9 into kotest:master May 27, 2021
@BartvHelvert BartvHelvert deleted the feat/arb_int_zero_inc branch May 28, 2021 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeoColman LeoColman LeoColman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BartvHelvert @sksamuel @LeoColman