Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated FloatShrinker and DoubleShrinker to regard mantissa bit count… #2379

Merged
merged 1 commit into from
Jul 26, 2021

Conversation

sielenk-yara
Copy link
Contributor

… as complexity measure

This is patch for #2378.

It does not realize a simplification base 10, though.

@sksamuel sksamuel merged commit cbbccb9 into kotest:master Jul 26, 2021
@sksamuel
Copy link
Member

Great stuff, thanks for fixing.

@sielenk
Copy link
Contributor

sielenk commented Jul 27, 2021

You're welcome (this is also me, sielenk-yara is my company account).

You do realize that this does not what is mentioned in #2378, though?
I am still thinking about getting it done platform-independently in base 10 but this is not yet it.

That said, I do think this is an improvement over the old shrinker which was kind of all over the place - but that is the task of the Arb!

@sksamuel
Copy link
Member

sksamuel commented Aug 1, 2021

yes I think this is fine for a JVM solution. I will include this in 4.6.2

@sielenk
Copy link
Contributor

sielenk commented Aug 1, 2021

This works on all platforms, not just JVM!

@sksamuel
Copy link
Member

sksamuel commented Aug 1, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants