Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved geo location generator #2390

Merged
merged 2 commits into from
Jul 30, 2021
Merged

Conversation

sielenk
Copy link
Contributor

@sielenk sielenk commented Jul 30, 2021

This morning I noticed that the Arb.latlon generator does not produce proper geo coordinates:

  • latitude should be in range -90°...+90° and
  • it should not be uniformly distributed in its range for the points on the sphere to be uniformly distributed

While updating I also added a dedicated class for geo locations with descriptive property names and degree and radian values.
Plus backward compatibility code with deprecation annotations with ReplaceWith hints.

@sksamuel
Copy link
Member

This is great, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants