Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autoClose lazyness #2395

Merged
merged 2 commits into from Aug 1, 2021
Merged

Conversation

nomisRev
Copy link
Contributor

@nomisRev nomisRev commented Aug 1, 2021

Closes #2388

@sksamuel
Copy link
Member

sksamuel commented Aug 1, 2021

Should we keep a test that autoclosables not wrapped in lazy by the user are still closed ?

@nomisRev
Copy link
Contributor Author

nomisRev commented Aug 1, 2021

I'll re-add it so we cover both functions.

@sksamuel sksamuel merged commit 77a7006 into kotest:master Aug 1, 2021
@sksamuel
Copy link
Member

sksamuel commented Aug 1, 2021

👍🏼

sksamuel pushed a commit that referenced this pull request Aug 24, 2021
* Fix autoClose lazyness

* Add test for autoClose and lazy autoClose
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

autoClose breaks Lazy
2 participants