Add BigDecimal edge case for equals vs compareTo discrepancy #2403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm looking for some guidance about how to best unit test this. My expectation is that with a proper seed I could get a 2-ary function to get both edge cases, but I'm not sure how simple that is, or if there's another approach to take here. |
|
You could just call the edge cases method multiple times and assert you get both of the 0.0 and 0.00 in the output. |
|
Something like |
dchenbecker
force-pushed
the
add-bigdecimal-edgecase
branch
from
c13f493 to
e82af64
Compare
BigDecimal is not consistent for equals and compareTo when the scale differs. This adds an edge case using the String constructor for BigDecimal to force a different scale.
dchenbecker
force-pushed
the
add-bigdecimal-edgecase
branch
from
e82af64 to
4e01bac
Compare
|
👍🏼 |
sksamuel
pushed a commit
that referenced
this pull request
Aug 24, 2021
BigDecimal is not consistent for equals and compareTo when the scale differs. This adds an edge case using the String constructor for BigDecimal to force a different scale.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BigDecimal is not consistent for equals and compareTo when the
scale differs. This adds an edge case using the String constructor for
BigDecimal to force a different scale.