Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Percentage tolerance matchers #2404

Merged
merged 1 commit into from
Aug 6, 2021

Conversation

LeoColman
Copy link
Member

Closes #2232

@LeoColman LeoColman added the enhancement ✨ Suggestions for adding new features or improving existing ones. label Aug 6, 2021
@LeoColman LeoColman requested review from a team August 6, 2021 18:42
@LeoColman LeoColman self-assigned this Aug 6, 2021
@sksamuel sksamuel merged commit 53dc754 into master Aug 6, 2021
@sksamuel sksamuel deleted the feature/2232-percentage-tolerance-matchers branch August 6, 2021 23:29
@ajalt ajalt mentioned this pull request Aug 18, 2021
@LouisCAD
Copy link
Contributor

LouisCAD commented Oct 9, 2022

Which version has these?
I'm unable to find shouldBeWithinPercentageOf in kotest 4.1.3

@LouisCAD
Copy link
Contributor

LouisCAD commented Oct 9, 2022

Wait, did the maven coordinates change again? 🤔

EDIT: Ok, I wasn't seeing newer versions because I was sharing the version with junit4 runner which apparently is not longer receiving updates.

@sksamuel
Copy link
Member

sksamuel commented Oct 9, 2022

junit4 is still being released, https://search.maven.org/artifact/io.kotest/kotest-runner-junit4-jvm/5.5.0/jar

shouldBeWithinPercentageOf is in the assertions core package which is still at https://search.maven.org/search?q=a:kotest-assertions-core-jvm

The only time we did a major change of coordinates was when 5.0 came out last year, and even then it was only the extensions packages for spring, ktor, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ Suggestions for adding new features or improving existing ones.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tolerance matcher to Float, Int and Long
3 participants