Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LocalDate arb generating wrong dates outside constraints #2405

Merged
merged 1 commit into from
Aug 8, 2021

Conversation

LeoColman
Copy link
Member

Fixes #2402

@LeoColman LeoColman requested a review from a team August 8, 2021 05:12
@sksamuel
Copy link
Member

sksamuel commented Aug 8, 2021

I thought we already had a fix for this ?

@sksamuel
Copy link
Member

sksamuel commented Aug 8, 2021

Is this related #2370

@LeoColman
Copy link
Member Author

I think that when the date was exactly feb 28 of a leap year some issues were arising. The exact test from #2402 was failing. I took it and tried to generalize to more scenarios. When I made that test pass I opened this PR.

I think it is related, but not completely.

@sksamuel sksamuel merged commit a8389b6 into master Aug 8, 2021
@sksamuel sksamuel deleted the bugfix/2402-localdate-arb branch August 8, 2021 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arb.LocalDate return the date before minDate
2 participants