Property Module: Allow global seed configuration. Synchronize defaults. #2439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix for incorrect value and name correct variable usages correct nullification
sksamuel
reviewed
Aug 25, 2021
sksamuel
reviewed
Aug 25, 2021
kotest-property/src/commonMain/kotlin/io/kotest/property/config.kt
Outdated
Show resolved
Hide resolved
sksamuel
reviewed
Aug 25, 2021
kotest-property/src/commonMain/kotlin/io/kotest/property/config.kt
Outdated
Show resolved
Hide resolved
|
Thanks for the PR. I've added some comments. |
I think kotest.proptest.anything.reasonable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for enhancement request #2438 (which I raised myself, and is open to critique)
PropTestConfigdata classPropTest,PropTestConfig, and the globalPropertyTestingobjectPropTestConfigvaluesoutputClassifiations. This is a recent addition so I'm not sure if it amounts to a breaking change yet? Correct me if I'm wrong pleaseNote: I have not added
syspropdeclarations for the new configurations as I am not sure what the exact pattern should be for their namespaces