New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: add logging to test context #2443

Merged

sksamuel merged 36 commits into master from jschneidereit/feature/1992-add-logging-to-testcontext

Sep 11, 2021

Member

jschneidereit commented Aug 28, 2021

Fixes #1992

jschneidereit commented

View reviewed changes

...rc/commonMain/kotlin/io/kotest/engine/test/extensions/CoroutineLoggingTestExecutionFilter.kt Outdated Show resolved Hide resolved

sksamuel reviewed

View reviewed changes

kotest-framework/kotest-framework-api/src/commonMain/kotlin/io/kotest/core/config/LogLevel.kt Outdated Show resolved Hide resolved

sksamuel reviewed

View reviewed changes

...kotest-framework-api/src/commonMain/kotlin/io/kotest/core/internal/KotestEngineProperties.kt Outdated Show resolved Hide resolved

sksamuel reviewed

View reviewed changes

...work/kotest-framework-engine/src/commonMain/kotlin/io/kotest/engine/test/TestCaseExecutor.kt Outdated Show resolved Hide resolved

sksamuel reviewed

View reviewed changes

...rc/commonMain/kotlin/io/kotest/engine/test/extensions/CoroutineLoggingTestExecutionFilter.kt Outdated Show resolved Hide resolved

sksamuel reviewed

View reviewed changes

...rc/commonMain/kotlin/io/kotest/engine/test/extensions/CoroutineLoggingTestExecutionFilter.kt Outdated Show resolved Hide resolved

sksamuel reviewed

View reviewed changes

...rc/commonMain/kotlin/io/kotest/engine/test/extensions/CoroutineLoggingTestExecutionFilter.kt Outdated Show resolved Hide resolved

sksamuel reviewed

View reviewed changes

...rc/commonMain/kotlin/io/kotest/engine/test/extensions/CoroutineLoggingTestExecutionFilter.kt Outdated Show resolved Hide resolved

jschneidereit self-assigned this

jschneidereit force-pushed the jschneidereit/feature/1992-add-logging-to-testcontext branch 5 times, most recently from ce63b1f to ea14c7d Compare

September 3, 2021 03:43

jschneidereit force-pushed the jschneidereit/feature/1992-add-logging-to-testcontext branch from 298c9d2 to 18e5b95 Compare

September 8, 2021 20:18

jschneidereit added 15 commits

September 9, 2021 10:33


          add logging to test context

6a56bc5


          I guess this file is code gen

0e53a1c


          no camel case for properties

fca6f97


          rename logging coroutine object to match test execution filter

b5ff2e8


          add logging filter regardless of config and rely on execute to check …

0c561e8

…loglevel


          docs should produce markdown files that respect .editorconfig

670d16c


          regenerate markdown file for updated config properties

14ac036


          rename consume to afterEach and and introduce SerialLogListener

5a1f3a9


          LogLevel shouldn't know about KotestEngineProperties

ed9b2ea


          move from listener to extension

88005b4


          add getLogger

b52f153


          add a comma

5dbea1a


          make test more clear

b67fb7d


          add trace and maintain log level information

5a57c26


          rename interceptor to match others

832efac

jschneidereit added 7 commits

September 9, 2021 10:35


          fix default loglevel

86c6a8f


          fix broken LogLevel

f8ddceb


          fix broken extensions in tests

6ca369a


          checking this in for help

b458df6


          changed a few things

a4fe47c


          all tests working

eaa3863


          get rid of the default console logger for now, probably should be in …

a880e2e

…gradle plugin and teamcity plugin

jschneidereit force-pushed the jschneidereit/feature/1992-add-logging-to-testcontext branch from 18e5b95 to a880e2e Compare

September 9, 2021 17:35

jschneidereit and others added 9 commits

September 10, 2021 14:23


          add logging to test context

627a3eb


          rename logging coroutine object to match test execution filter

219b13d


          rename consume to afterEach and and introduce SerialLogListener

98c90c8


          move from listener to extension

939568e


          add logging to test context

999ef01


          rename logging coroutine object to match test execution filter

7dbc50a


          add logging filter regardless of config and rely on execute to check …

fcace0e

…loglevel


          rename consume to afterEach and and introduce SerialLogListener

60aa6d4


          Added tests for ExceptionCapturingTestExecutionInterceptor

15d1818

sksamuel reviewed

View reviewed changes

...gine/src/commonMain/kotlin/io/kotest/engine/test/interceptors/CoroutineLoggingInterceptor.kt Outdated

+                          val logs = mutableListOf<LogEntry>()
+                          val contextWithLogging = context.withCoroutineContext(TestContextLoggingCoroutineContextElement(logs))
+                          try {
+                             test(testCase, contextWithLogging)

Member

sksamuel Sep 10, 2021

You might want to wrap test(testCase, contextWithLogging) with a withContext call, because otherwise, downstream interceptors can change it without realizing.
I will fix this up.

sksamuel reviewed

View reviewed changes

...gine/src/commonMain/kotlin/io/kotest/engine/test/interceptors/CoroutineLoggingInterceptor.kt Outdated

+                 }
+              }
+              typealias LogFn = suspend () -> Any

Member

sksamuel Sep 10, 2021

I'd remove suspend on logging


          updates

7de1482

sksamuel approved these changes

View reviewed changes

sksamuel added 3 commits

September 10, 2021 14:33


          updates

5e3748f


          updates

95a2dc3


          updates

c42983a

sksamuel approved these changes

View reviewed changes


          updates

e78d1f8

sksamuel merged commit cb8a17f into master

sksamuel deleted the jschneidereit/feature/1992-add-logging-to-testcontext branch

September 11, 2021 21:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet