Add support for Linux ARM64 and macOS ARM64 (Silicon) targets.

[charleskorn]

Currently blocked until a new version of kotlinx.coroutines is published with these targets (see Kotlin/kotlinx.coroutines#2904).

See #1743 (comment).

[JavierSegoviaCordoba]

Can you add the new Apple simulator targets too (ios tvos and watchos)?

[charleskorn]

Can you add the new Apple simulator targets too (ios tvos and watchos)?

Done.

[charleskorn]

Looks like #2450 broke some tests - could you take a look @sksamuel?

[JavierSegoviaCordoba]

Coroutines 1.5.2 and mt are available.

[sksamuel]

I hope 1.5.2 fixes my issue with Result cast exceptions :)

[sksamuel]

Looks like #2450 broke some tests - could you take a look @sksamuel?

Yep

[charleskorn]

This is ready for review @sksamuel.

[sksamuel]

Awesome 👍🏼

[sksamuel]

Don't know if this error means anything to you @charleskorn https://github.com/kotest/kotest/runs/3507598103?check_suite_focus=true

[JavierSegoviaCordoba]

Not sure if kotlin.native.enableDependencyPropagation=false in gradle.properties can fix that

[JavierSegoviaCordoba]

@sksamuel linuxArm64 isn't in kotlin coroutines:

        addTarget(presets.linuxX64)
        addTarget(presets.iosArm64)
        addTarget(presets.iosArm32)
        addTarget(presets.iosX64)
        addTarget(presets.macosX64)
        addTarget(presets.mingwX64)
        addTarget(presets.tvosArm64)
        addTarget(presets.tvosX64)
        addTarget(presets.watchosArm32)
        addTarget(presets.watchosArm64)
        addTarget(presets.watchosX86)
        addTarget(presets.watchosX64)
        addTarget(presets.iosSimulatorArm64)
        addTarget(presets.watchosSimulatorArm64)
        addTarget(presets.tvosSimulatorArm64)
        addTarget(presets.macosArm64)

[sksamuel]

The PR passed. I guess the PR workflow wasn't updated the same as the master workflow.

[JavierSegoviaCordoba]

we should ask in coroutines for this target, but it is strange it doesn't exist yet

[JavierSegoviaCordoba]

Kotlin/kotlinx.coroutines#855

[charleskorn]

Don't know if this error means anything to you @charleskorn https://github.com/kotest/kotest/runs/3507598103?check_suite_focus=true

Yep, that would be because kotlinx.coroutines doesn't support linuxArm64.

The PR passed. I guess the PR workflow wasn't updated the same as the master workflow.

The Linux PR workflow runs check, which should run everything that can be run on Linux (including building Linux ARM64 targets but not testing them), not sure why it didn't pick this up.

we should ask in coroutines for this target, but it is strange it doesn't exist yet

Sounds great, thanks for doing that.

In the meantime, do you want me to remove the linuxArm64 targets?

[sksamuel]

I think we should remove them for now yeah.

…

On Sat, 4 Sept 2021 at 00:20, Charles Korn ***@***.***> wrote: Don't know if this error means anything to you @charleskorn <https://github.com/charleskorn> https://github.com/kotest/kotest/runs/3507598103?check_suite_focus=true Yep, that would be because kotlinx.coroutines doesn't support linuxArm64. The PR passed. I guess the PR workflow wasn't updated the same as the master workflow. The Linux PR workflow runs check <https://github.com/kotest/kotest/pull/2449/files#diff-db41ffe2c658df28e2cc8e19c303f1b0942d56b6fb1b0fedc2dc3b916e005b00R28>, which should run everything that can be run on Linux (including building Linux ARM64 targets but not testing them), not sure why it didn't pick this up. we should ask in coroutines for this target, but it is strange it doesn't exist yet Sounds great, thanks for doing that. In the meantime, do you want me to remove the linuxArm64 targets? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2449 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFVSGVNJ5543CQ3ABRVFR3UAGUABANCNFSM5DFP4CNQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[charleskorn]

I've opened #2460 to remove the Linux ARM64 target.

[JavierSegoviaCordoba]

I created it too, but I forgot to modify the workflows, I will close it