-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Property Module: Mutation of global PropertyTesting fix for Kotlin/Native #2469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix for incorrect value and name correct variable usages correct nullification
…possible; sysprop improvements
# Conflicts: # kotest-property/src/commonMain/kotlin/io/kotest/property/config.kt
# Conflicts: # kotest-property/src/commonMain/kotlin/io/kotest/property/config.kt
# Conflicts: # kotest-property/src/commonMain/kotlin/io/kotest/property/config.kt
Remove unused property test
…est into fix-native-configuration
Native memory models is a bit out of my wheelhouse but I think I basically follow it. Could probably use this for the config for the main framework too (do you use kotest framework or just kotest prop test?) |
We've just been using prop-test so far, but looking at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2440
Allows Kotlin/Native modification of the PropertyTesting configuration object's properties.
get
/set
delegation byReadWriteProperty
to use Atomic properties like common Kotlin variables.