shouldBeEqualToComparingFields handles arrays and computed properties #2475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kantis
commented
Sep 8, 2021
| "${it.name}: ${actual.show().value} != ${expected.show().value}" | ||
| } | ||
|
|
||
| val isEqual = eq(actual, expected) == null |
There was a problem hiding this comment.
Using eq gives us handling of arrays for free.. could it cause other problems? It feels like a nice way to delegate responsibility of equality, IMO
There was a problem hiding this comment.
Using eq will be okay, I don't see any problem using it.
Bridge and synthetic methods are added by the compiler. So we should just ignore those (if they even show up). |
|
Don't need to worry about changelog for bugs - I will compile a full list of fixed bugs when I release the next version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #2375
I didn't quite get the part regarding
bridgemodifier from the issue discussion. What kind of construct is required to create abridgefield?TODO: