Remove inconsistent exceptionClass default values #2831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why some `eventually` methods has it set to `Throwable` and some doesn't? I suggest to remove it. Or if we want to keep it, put it as defaualt value to `EventuallyConfig`'sa constructor instead of `null`.
|
Looks like a build failure. |
|
@sksamuel Tests are now fixed. 💪🏻 |
sksamuel
reviewed
Feb 22, 2022
| @@ -46,14 +46,14 @@ class EventuallyTest : WordSpec() { | |||
| } | |||
| "pass tests that completed within the time allowed" { | |||
| val end = System.currentTimeMillis() + 150 | |||
| eventually(1.seconds) { | |||
| eventually(1.seconds, RuntimeException::class) { | |||
There was a problem hiding this comment.
Would this test fail now if we didn't add the exception ?
Will it break existing users code in other words ?
There was a problem hiding this comment.
Yes, it will. Other proposed solution might be to add Throwable to configuration's default constructor. Then it shouldn't break existing code, so changes to tests might be reverted. Should I do it?
|
Yes, we can't break anything.
…On Wed, 23 Feb 2022, 02:31 Ing. Jan Kaláb, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
kotest-assertions/kotest-assertions-core/src/jvmTest/kotlin/com/sksamuel/kotest/assertions/timing/EventuallyTest.kt
<#2831 (comment)>:
> @@ -46,14 +46,14 @@ class EventuallyTest : WordSpec() {
}
"pass tests that completed within the time allowed" {
val end = System.currentTimeMillis() + 150
- eventually(1.seconds) {
+ eventually(1.seconds, RuntimeException::class) {
Yes, it will. Other proposed solution might be to add Throwable to
configuration's default constructor. Then it shouldn't break existing code,
so changes to tests might be reverted. Should I do it?
—
Reply to this email directly, view it on GitHub
<#2831 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFVSGTV5DGA24UZWP6GQ2DU4SLOHANCNFSM5OQ6VLFA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@sksamuel Ok, now it should be as you want. 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why some
eventuallymethods has it set toThrowableand some doesn't? I suggest to remove it. Or if we want to keep it, put it as defaualt value toEventuallyConfig'sa constructor instead ofnull.