Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix random spec sorter creating invalid comparator #2840

Merged
merged 1 commit into from
Feb 21, 2022
Merged

Fix random spec sorter creating invalid comparator #2840

merged 1 commit into from
Feb 21, 2022

Conversation

myuwono
Copy link
Contributor

@myuwono myuwono commented Feb 21, 2022

In this PR

  • Fix the implementation of RandomSpecSorter::sort to use list.shuffled instead of comparator.

fixes #2839

@sksamuel sksamuel merged commit be0d8c9 into master Feb 21, 2022
@sksamuel sksamuel deleted the bugfix/fix-random-spec-sorter branch February 21, 2022 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sksamuel sksamuel Awaiting requested review from sksamuel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RandomSpecSorter occasionally crashes kotest with "Comparison method violates its general contract!"
2 participants
@myuwono @sksamuel