Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore uniqueid selectors for better interop with other engines #2862

Merged
merged 2 commits into from
Mar 12, 2022
Merged

ignore uniqueid selectors for better interop with other engines #2862

merged 2 commits into from
Mar 12, 2022

Conversation

christophsturm
Copy link
Contributor

fixes #2806

@sksamuel
Copy link
Member

Should we only ignore unique id if the engine part of the unique id is != kotest ?

@christophsturm
Copy link
Contributor Author

does kotest support executing tests by uniqueid? or should it just run all tests for a uniqueid that has the kotest engine descriptor?

@sksamuel
Copy link
Member

I would just throw an error if engine is kotest and this selector is found.

@sksamuel
Copy link
Member

sksamuel commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kotest should respect engine name in junit platform launcher
2 participants