-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for coroutines #332
Conversation
Both builds seem to have failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jereksel , this it what I wanted
zipStoreBase=GRADLE_USER_HOME | ||
zipStorePath=wrapper/dists | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-4.6-all.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not 4.7 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4.7 has a bug, see #336
fun When(name: String, test: WhenContext.() -> Unit) = `when`(name, test) | ||
fun `when`(name: String, test: WhenContext.() -> Unit) = add("When: $name", test) | ||
private fun add(name: String, test: WhenContext.() -> Unit) = | ||
fun And(name: String, test: suspend WhenContext.() -> Unit) = and(name, test) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what is better, however possible right solution is duplicate functions: with corotines support and without it
Is there a way we can disable coroutines, maybe even by default? Otherwise the mix of Gradle 4.8, kotlintest 3.1.6 and
|
I can make it so there's two versions of the functions. |
Not sure if that helps as coroutines would still be generally enabled on the Gradle-level... |
Yes of course, doh. Ok maybe it will have to be another module |
@sksamuel , I see, that coroutines support is missed after version 3.1.6. How it is better to enabled it back? |
Closes #323