fix eventually nanos conversion #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great spot thanks! |
|
I've released 3.1.4 with this fix. Thanks again. |
|
👍 - thanks for the quick release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrading from kotlintest 2->3, some of our tests failed because eventually wasn't waiting nearly long enough. Looks like as part of the migration to use Duration, there was some bad math in converting millis to nanos. There are
1_000_000nanos in a millisecond, not1_000(I had to look this up - I would've thought it was a thousand too!).Adjusting the test as I did below without modifying Eventually.kt shows the issue, and fails with an error like this:
java.lang.AssertionError: Test failed after 3 seconds; attempted 942 times