Fix table testing forNone and Double between matcher #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, `forNone` will never fail. If the callback succeeds, an `AssertionError` is thrown, but it's immediately caught by the try/catch that's meant to catch failures in the callback. This PR also fixes the `between` matcher, which was passing its tests due to `forNone` not working.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
forNonewill never fail. If the callback succeeds, anAssertionErroris thrown, but it's immediately caught by the try/catch that's meant to catch failures in the callback.This PR also fixes the
betweenmatcher for Doubles, which was incorrectly passing its tests due toforNonenot working.