Implement expected exception for AnnotationSpec #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sksamuel
reviewed
Jan 14, 2019
JUnit's tests can test an exception is thrown by using a parameter in the `@Test` annotation. https://github.com/junit-team/junit4/wiki/exception-testing Although we support `shouldThrow` and it's variants, we're trying to improve the likelihood of people using KotlinTest instead of JUnit, by making the migration as easy as possible. Because of this objective, this commit implements a parameter in `@Test`, to enable users to configure an expected exception just like JUnit's. To do this, this commit creates the parameter and annotation processing for it. To reuse code, this commit copies some internal classes around, to enable `kotlintest-core` module to use some of the classes from `kotlintest-assertions` and `kotlintest-runner-jvm`. This doesn't impact any user, as the classes were copied. However, they're marked for deletion soon-ish. To test that the new behavior works, this commit uses `SpecLevelExtension` to map specific tests with specific behaviors. It's not very pretty, but it works. Fixes #527
LeoColman
force-pushed
the
feature/527-expected-for-annotation-spec
branch
from
4754dcf
to
65e2108
Compare
|
If we're ok with this, we should keep this PR opened until we release 3.2.0. But is everything fine now? |
|
Yep merge after 3.2.0 |
|
Approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JUnit's tests can test an exception is thrown by using a parameter in the
@Testannotation. https://github.com/junit-team/junit4/wiki/exception-testingAlthough we support
shouldThrowand it's variants, we're trying to improve the likelihood of people using KotlinTest instead of JUnit, by making the migration as easy as possible. Because of this objective, this commit implements a parameter in@Test, to enable users to configure an expected exception just like JUnit's.To do this, this commit creates the parameter and annotation processing for it.
To reuse code, this commit moves some internal classes around, to enable
kotlintest-coremodule to use some of the classes fromkotlintest-assertionsandkotlintest-runner-jvm. This doesn't impact any user, as the moved classes and functions are internal/private.To test that the new behavior works, this commit uses
SpecLevelExtensionto map specific tests with specific behaviors. It's not very pretty, but it works.Fixes #527