Clarify documentation for TestConfig.invocations #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users weren't completely sure of how invocations worked. It was possible to think that you wouldn't need all invocations to pass for a test to succeed. This commit clarifies in the documentation that for a test to pass, all it's invocations must pass, otherwise it will fail. Fixes #591
sksamuel
approved these changes
Jan 18, 2019
sschuberth
approved these changes
Jan 18, 2019
LeoColman
deleted the
feature/591-clarify-documentation-for-invocations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users weren't completely sure of how invocations worked. It was possible to think that you wouldn't need all invocations to pass for a test to succeed.
This commit clarifies in the documentation that for a test to pass, all it's invocations must pass, otherwise it will fail.
Fixes #591