SystemProperty Test Helpers #524 #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeoColman
reviewed
Jan 24, 2019
kotlintest-assertions/src/main/kotlin/io/kotlintest/assertions/sysprops.kt
Outdated
Show resolved
Hide resolved
kotlintest-assertions/src/main/kotlin/io/kotlintest/assertions/sysprops.kt
Show resolved
Hide resolved
|
Do you think it's worth to add a |
|
Missing documentation on how to use this |
Added system extension. Documentation will come as a separate PR. |
LeoColman
reviewed
Jan 25, 2019
|
Yes. The reason they're split is for people who want to use our assertions
but with junit (or spek even!).
But if you're using our test framework, then you're not going to mind one
more small dep.
…On Fri, 25 Jan 2019 at 14:29, Leonardo Colman Lopes < ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In kotlintest-core/build.gradle
<#608 (comment)>:
> @@ -1,4 +1,5 @@
dependencies {
+ compile project(':kotlintest-assertions')
We had a discussion about this a while back. Do you think it's ok for core
to depend on assertions now?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#608 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAtZGkpKg8DfbOpm5BIpoLHzwB6Cuahjks5vGxTXgaJpZM4aR2s6>
.
|
LeoColman
approved these changes
Jan 26, 2019
This was referenced Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.