Remove all deprecated matchers/assertions #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes all `shouldBe` kind of matchers/assertions that were deprecated. Some were already moved to another package, some are not the correct usage anymore. They're deprecated quite some time, and are now being removed. Closes #651
|
I don't think there is any other matcher to remove |
|
But we can discuss if we want to remove |
sksamuel
requested changes
Feb 13, 2019
kotlintest-assertions/src/main/kotlin/io/kotlintest/matchers/StringMatchers.kt
Show resolved
Hide resolved
kotlintest-assertions/src/main/kotlin/io/kotlintest/matchers/collections/matchers.kt
Show resolved
Hide resolved
kotlintest-assertions/src/main/kotlin/io/kotlintest/matchers/collections/matchers.kt
Show resolved
Hide resolved
I think no, as they only got deprecated a month ago. 3.4 for those. |
|
No prob. Let's merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes all
shouldBekind of matchers/assertions that were deprecated. Some were already moved to another package, some are not the correct usage anymore.They're deprecated quite some time, and are now being removed.
Closes #651