Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more primative gens #773

Merged
merged 4 commits into from
May 22, 2019
Merged

Add more primative gens #773

merged 4 commits into from
May 22, 2019

Conversation

magneticflux-
Copy link
Contributor

Closes #772

@magneticflux- magneticflux- changed the title Add Short and Byte gens Add more primative gens May 16, 2019
@LeoColman LeoColman self-requested a review May 16, 2019 17:20
@magneticflux-
Add gens for experimental unsigned types
64ba836 
They aren't inferred because they're experimental for now
@magneticflux- magneticflux- marked this pull request as ready for review May 16, 2019 17:26
@sksamuel
Copy link
Member

lgtm merge when you're happy @Kerooker

@sksamuel
Copy link
Member

Thanks for the pr @magneticflux-

LeoColman
LeoColman requested changes May 21, 2019
View reviewed changes
Copy link
Member

@LeoColman LeoColman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add some tests for the new generators, to ensure that we won't break them in the future. If you can't create the tests right now or whatever reason, please let us now, and we can do it for you :)

@magneticflux-
Copy link
Contributor Author

I added to some existing tests, but I didn't see any other tests for the original Int and Long gens to parallel for Short and Byte. If you want more tests, just link where I should put them and I'll add them!

@LeoColman
Copy link
Member

I think we're ok for now.
I'll add some tests for all of these later.

Thanks for the PR, @magneticflux- !

@LeoColman LeoColman merged commit 69f93a8 into kotest:master May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeoColman LeoColman LeoColman requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generators for Byte, Short, and experimental unsigned types
3 participants
@magneticflux- @sksamuel @LeoColman