added asClue helper and rewrote withClue to allow nesting
#784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeoColman
requested changes
May 26, 2019
kotlintest-assertions/src/main/kotlin/io/kotlintest/matchers/matchers.kt
Outdated
Show resolved
Hide resolved
|
Thanks :). Trying to give back some of the joy I'm having when using the framework ;). |
|
Good for me. Whenever you want it, @sksamuel |
LeoColman
approved these changes
May 27, 2019
|
lgtm
…On Mon, 27 May 2019 at 08:29, Leonardo Colman Lopes < ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#784>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAFVSGRF56JMC62H2RGB2CLPXPO3FANCNFSM4HPXHZOA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #783
I changed to formatting of the former
withClueto add newlines after each clue, since I think this is more readable, especially when using data classes as clue. Additionally, I allowed returning something from the body (in both cases). It is not strictly needed for these cases, but sometimes comes in handy to write code in an immutable way and does not hurt either.