Ensure specs that fail in initialisation fail a Maven build #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KotlinTest fails to notify the Maven Surefire plugin properly via the JUnit platform if a spec throws an exception during initialisation. This is because whilst `TestEngine` does try to register a spec that fails during initialisation, it accidentally skips the beforeSpecClass and afterSpecClass methods on the `TestEngineListener` because it is wrapped in an `IsolationTestEngineListener` which has guards around those methods, and the guards always return false because the spec was never created. See https://github.com/Mahoney/maven-kotlintest for an example of the problem.
|
I think this is a little bit related to #807 |
|
Ah nice spot. @Kerooker do you think this would fix what you were adding in your PR ? |
|
No.
I think that they might complement each other. This isn't a fix for that
issue
…On Sat, Jun 15, 2019 at 1:20 AM Stephen Samuel ***@***.***> wrote:
Ah nice spot. @Kerooker <https://github.com/Kerooker> do you think this
would fix what you were adding in your PR ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#832>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAMBCIYVPOWC3YJWQC3KK23P2RUYBANCNFSM4HYKPAXQ>
.
--
Atenciosamente,
Leonardo Colman Lopes
|
|
Ok, this is important too. Let's merge this?
On Fri, 14 Jun 2019 at 23:29, Leonardo Colman Lopes <
notifications@github.com> wrote:
… No.
I think that they might complement each other. This isn't a fix for that
issue
On Sat, Jun 15, 2019 at 1:20 AM Stephen Samuel ***@***.***>
wrote:
> Ah nice spot. @Kerooker <https://github.com/Kerooker> do you think this
> would fix what you were adding in your PR ?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <
#832
>,
> or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/AAMBCIYVPOWC3YJWQC3KK23P2RUYBANCNFSM4HYKPAXQ
>
> .
>
--
Atenciosamente,
Leonardo Colman Lopes
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#832>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAFVSGVEUG6QQHS7LYKLSNTP2RV37ANCNFSM4HYKPAXQ>
.
|
|
Makes sense. Merged. |
Mahoney
pushed a commit
to Mahoney-forks/kotlintest
that referenced
this pull request
Jun 18, 2019
KotlinTest fails to notify the Maven Surefire plugin properly via the JUnit platform if a spec throws an exception during initialisation. This is because whilst `TestEngine` does try to register a spec that fails during initialisation, it accidentally skips the beforeSpecClass and afterSpecClass methods on the `TestEngineListener` because it is wrapped in an `IsolationTestEngineListener` which has guards around those methods, and the guards always return false because the spec was never created. See https://github.com/Mahoney/maven-kotlintest for an example of the problem. (cherry picked from commit b99f7f7)
sksamuel
pushed a commit
that referenced
this pull request
Jun 29, 2019
KotlinTest fails to notify the Maven Surefire plugin properly via the JUnit platform if a spec throws an exception during initialisation. This is because whilst `TestEngine` does try to register a spec that fails during initialisation, it accidentally skips the beforeSpecClass and afterSpecClass methods on the `TestEngineListener` because it is wrapped in an `IsolationTestEngineListener` which has guards around those methods, and the guards always return false because the spec was never created. See https://github.com/Mahoney/maven-kotlintest for an example of the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KotlinTest fails to notify the Maven Surefire plugin properly via the
JUnit platform if a spec throws an exception during initialisation.
This is because whilst
TestEnginedoes try to register a spec thatfails during initialisation, it accidentally skips the beforeSpecClass
and afterSpecClass methods on the
TestEngineListenerbecause it iswrapped in an
IsolationTestEngineListenerwhich has guards aroundthose methods, and the guards always return false because the spec was
never created.
See https://github.com/Mahoney/maven-kotlintest for an example of the
problem.