Add possibility of configuration to Environment Listeners

[LeoColman]

Closes #829

[LeoColman]

I think that I might be missing some tests here, but I'm not sure

[sksamuel]

As usual from your PRs it's great, but I think we should allow all three options now.

[sksamuel]

Agreed.

…

On Fri, 28 Jun 2019, 12:05 Leonardo Colman Lopes, ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In kotlintest-extensions/src/main/kotlin/io/kotlintest/extensions/system/MapOverrides.kt <#843 (comment)>: > @@ -1,12 +1,34 @@ package io.kotlintest.extensions.system + +enum class SystemOverrideMode { ALLOW_OVERRIDE, DENY_OVERRIDE } My only point to this is that SET_OR_OVERRIDE should be set as default. It's the default now, and I don't think we need to change that behavior and potentially break clients — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#843>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAFVSGR7JJIJ6MHBLFKKMK3P4ZAELANCNFSM4HZNP5UA> .

[LeoColman]

@sksamuel I think it's done.

Please review again!

[LeoColman]

I decided that setting the default to SetOrError is better. It should be the expected, and if clients' code break, it is a good thing

[sksamuel]

Do you want me to finish this off?

…

On Wed, 10 Jul 2019 at 10:15, Leonardo Colman Lopes < ***@***.***> wrote: I decided that setting the default to SetOrError is better. It should be the expected, and if clients' code break, it is a good thing — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#843>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAFVSGVN7AFENTS6Y7LYCBLP6X4KRANCNFSM4HZNP5UA> .

[LeoColman]

Did I miss anything?

[sksamuel]

Don't think so

…

On Wed, 10 Jul 2019, 14:48 Leonardo Colman Lopes, ***@***.***> wrote: Did I miss anything? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#843>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAFVSGQZ4QSLUOEZGSZVZ63P6Y4HPANCNFSM4HZNP5UA> .