Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed autoClose to accept an AutoCloseable #847

Merged
merged 1 commit into from
Jun 21, 2019

Conversation

xenomachina
Copy link
Contributor

Previously autoClose's parameter was a Closeable. Unfortunately, some
classes implement AutoCloseable but not Closeable (JDBC and
testcontainers are a couple of examples).

Closeable extends AutoCloseable, so autoClose will continue working with
Closeable objects.

Previously autoClose's parameter was a Closeable. Unfortunately, some
classes implement AutoCloseable but not Closeable (JDBC and
testcontainers are a couple of examples).

Closeable extends AutoCloseable, so autoClose will continue working with
Closeable objects.
@sksamuel
Copy link
Member

lgtm @Kerooker

@sksamuel sksamuel merged commit f972d29 into kotest:master Jun 21, 2019
@xenomachina xenomachina deleted the autoClose-AutoCloseable branch June 21, 2019 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants