Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added shouldBeZero and shouldNotBeZero matcher for number types (#819) #848

Merged
merged 6 commits into from
Jun 23, 2019

Conversation

faogustavo
Copy link
Contributor

@faogustavo faogustavo commented Jun 20, 2019

Closes #819

I've also added the same matcher for floats (idn if it was necessary, because if it was not described on the task).
Also, there was a matcher file with just a couple of rules on the numerics package, so I joined with the existing one with more rules. Did the same with floats with to keep the same pattern from other numerics.

Copy link

@hjJunior hjJunior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great, just give another look about new line at end of file

@sksamuel sksamuel self-requested a review June 21, 2019 13:57
Copy link
Member

@sksamuel sksamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The zero stuff is awesome and can be merged.
The float stuff needs change as per request.
Thanks!

@sksamuel
Copy link
Member

sksamuel commented Jun 21, 2019 via email

@faogustavo
Copy link
Contributor Author

@sksamuel can you see if it's ok now?

@sksamuel sksamuel merged commit 916205d into kotest:master Jun 23, 2019
@sksamuel
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ShouldBeZero matcher
3 participants