Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added matchers for Result (#836) #861

Merged
merged 4 commits into from
Jul 3, 2019

Conversation

faogustavo
Copy link
Contributor

@faogustavo faogustavo commented Jun 23, 2019

Closes #836


Before making a review, please, go see the issue. I reported a problem there and it's blocking the PR.

@sksamuel
Copy link
Member

I can't merge yet as it says branch is out of date.

@faogustavo
Copy link
Contributor Author

I can't merge yet as it says branch is out of date.

Make sense merge if the tests are not passing by the problem that I reported on the issue?

@sksamuel
Copy link
Member

I think it just means you need to rebase or something. Not quite sure. Try making another fork/branch and copying the changes in.

@faogustavo
Copy link
Contributor Author

faogustavo commented Jun 24, 2019

I think it just means you need to rebase or something. Not quite sure. Try making another fork/branch and copying the changes in.

Actually, this PR is up-to-date, but it's a draft. I was planning to remove the draft when I understand and solve the problem I reported on the issue. Have you seen my comment there?

@LeoColman
Copy link
Member

There seem to be some failing tests tho.

Could you take a look at them?

@sksamuel
Copy link
Member

I think it just means you need to rebase or something. Not quite sure. Try making another fork/branch and copying the changes in.

Actually, this PR is up-to-date, but it's a draft. I was planning to remove the draft when I understand and solve the problem I reported on the issue. Have you seen my comment there?

No I didn't see your comment ?

@sksamuel
Copy link
Member

What is this waiting on? Do I need to do something?

@faogustavo
Copy link
Contributor Author

We are waiting for the issue on kotlin to be solved. Please, see the issue from this task, #836 Everything is detailed there

@faogustavo
Copy link
Contributor Author

I just pushed the workaround suggested by @sksamuel on the issue. We need to keep tracking the issue on kotlin issue tracker to solve this.

@faogustavo faogustavo marked this pull request as ready for review July 2, 2019 22:12
@sksamuel sksamuel merged commit ed38ba1 into kotest:master Jul 3, 2019
@sksamuel
Copy link
Member

sksamuel commented Jul 3, 2019

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add matchers for Result
3 participants