-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added matchers for Result (#836) #861
Conversation
kotlintest-assertions/src/main/kotlin/io/kotlintest/matchers/result/matchers.kt
Outdated
Show resolved
Hide resolved
I can't merge yet as it says branch is out of date. |
Make sense merge if the tests are not passing by the problem that I reported on the issue? |
I think it just means you need to rebase or something. Not quite sure. Try making another fork/branch and copying the changes in. |
Actually, this PR is up-to-date, but it's a draft. I was planning to remove the draft when I understand and solve the problem I reported on the issue. Have you seen my comment there? |
There seem to be some failing tests tho. Could you take a look at them? |
No I didn't see your comment ? |
kotlintest-assertions/src/main/kotlin/io/kotlintest/matchers/result/matchers.kt
Outdated
Show resolved
Hide resolved
What is this waiting on? Do I need to do something? |
We are waiting for the issue on kotlin to be solved. Please, see the issue from this task, #836 Everything is detailed there |
I just pushed the workaround suggested by @sksamuel on the issue. We need to keep tracking the issue on kotlin issue tracker to solve this. |
👍 |
Closes #836
Before making a review, please, go see the issue. I reported a problem there and it's blocking the PR.