Introduced await as a more feature rich version of eventually for whe… #888
Conversation
…n you want to use custom polling periods #793
|
Did you bring these guys straight from Awaitility? Some of them? |
| @@ -1,5 +1,8 @@ | |||
| package io.kotlintest | |||
| package io.kotlintest.eventually | |||
There was a problem hiding this comment.
Moving this guy to another package breaks client's code.
If it breaks already, we don't even need to deprecate, I suppose
There was a problem hiding this comment.
I'll add a deprecated alias.
| class FibonacciPollInterval(private val base: Duration, private val offset: Int) : PollInterval { | ||
|
|
||
| init { | ||
| if (offset <= -1) { |
There was a problem hiding this comment.
require(offset >0) { "message" }
| * | ||
| * @since 1.7.0 | ||
| */ | ||
| interface PollInterval { |
There was a problem hiding this comment.
We need to improve docs on this class
|
I think that await might not be the best name here. It is very used in CoRoutines |
|
await is only used in coroutines as part of deferred, not as a standalone function, so it won't clash. I could call it |
|
I've renamed it Please merge if you're happy. |
…n you want to use custom polling periods #793