Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried the assertions today and I felt that the assertion can be a bit more expressive.
I added some more asserts, usage examples can be found in tests.
I had a bit of a dilemma when testing success/failure values, between:
Try.Success("foo") shouldBeSuccess { it shouldBe "foo" }
and
Try.Success("foo") shouldBeSuccess { this shouldBe "foo" }
I also noticed that diffs are not properly highlighted in IntelliJ for
shouldBeSuccess [value]
. That's why I delegated testing failure equality toequalityMatcher
. The result can be compared easier with IntelliJ, at the cost of losing theFailure()
wrapper.Other changes:
.editorconfig
with some basic rules