Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Array overloads to collection matchers #904

Merged
merged 1 commit into from
Jul 19, 2019
Merged

Add Array overloads to collection matchers #904

merged 1 commit into from
Jul 19, 2019

Conversation

LeoColman
Copy link
Member

Closes #900

@LeoColman LeoColman requested a review from sksamuel July 19, 2019 15:32
@LeoColman
Copy link
Member Author

What I did here was to exactly duplicate all the matchers, but change them to Array. I also added some overloads in which the parameter type was Collection to suppor Array as well.

@LeoColman
Copy link
Member Author

One thing I didn't do was add overloads to all primitive array types, such as ByteArray or IntArray. There would be too many overloads if i did this.

It can be done if we want tho

@LeoColman LeoColman merged commit b707035 into master Jul 19, 2019
@LeoColman LeoColman deleted the feature/900-array-overloads branch July 19, 2019 17:08
@LeoColman
Copy link
Member Author

I don't think we need documentation for this, right? One can use the collections documentation

@sksamuel
Copy link
Member

sksamuel commented Jul 20, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sksamuel sksamuel sksamuel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Our collection matchers don't work on arrays
2 participants
@LeoColman @sksamuel