Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jsoup matchers #1028

Open
faogustavo opened this issue Oct 1, 2019 · 11 comments

Comments

@faogustavo
Copy link
Contributor

@faogustavo faogustavo commented Oct 1, 2019

skrape{it} is a Kotlin-based HTML/XML testing and web scraping library that can be used seamlessly in Spring-Boot, Ktor, Android or other Kotlin-JVM projects.

They want to add a lot of matchers and support the KotlinTest library (You can see all the expected matchers in this issue). If you are comfortable with this, I can implement those matchers myself.

Most of them, are matchers from jsoup library and can be added to the project as an extension and be used by other projects, beside the skrape{it}.

@Kerooker

This comment has been minimized.

Copy link
Member

@Kerooker Kerooker commented Oct 1, 2019

Sure, go ahead!
I believe we can add an assertions module for skrape.it.

The mantainers of the project already said that support can be mantained here (just like we do for Arrow and KTor).

I don't see a reason why not.

@Kerooker

This comment has been minimized.

Copy link
Member

@Kerooker Kerooker commented Oct 1, 2019

If you need any help configuring the new module, let me know

@faogustavo

This comment has been minimized.

Copy link
Contributor Author

@faogustavo faogustavo commented Oct 1, 2019

Alright. Thanks @Kerooker

@sksamuel

This comment has been minimized.

Copy link
Member

@sksamuel sksamuel commented Oct 1, 2019

I think kotest-assertions-skrape would be a good addition.

@faogustavo

This comment has been minimized.

Copy link
Contributor Author

@faogustavo faogustavo commented Oct 1, 2019

@sksamuel as the lib just wants to add some assertations to jsoup classes, isn't it better to add a kotest-assertations-jsoup?

@sksamuel

This comment has been minimized.

Copy link
Member

@sksamuel sksamuel commented Oct 1, 2019

Yes sorry.

@Kerooker

This comment has been minimized.

Copy link
Member

@Kerooker Kerooker commented Oct 1, 2019

Oh, I didn't see that. I thought the matchers were for the lib itself. Guess I didn't read it properly =S

@faogustavo faogustavo changed the title Add skrape.it matchers Add jsoup matchers Oct 1, 2019
@sksamuel

This comment has been minimized.

Copy link
Member

@sksamuel sksamuel commented Oct 2, 2019

@faogustavo

This comment has been minimized.

Copy link
Contributor Author

@faogustavo faogustavo commented Oct 2, 2019

Yeps, my plan is to start with the JSOUP assertations that are more generic and than add some others that are specific from the skrape.it;

I already started the JSOUP and hope to open a PR with some basic matchers soon.

@faogustavo

This comment has been minimized.

Copy link
Contributor Author

@faogustavo faogustavo commented Oct 22, 2019

Hey guys.
Unfortunately, I'm a little bit busy these days and will not be able to add more matchers to jsoup. I just removed the WIP from the PR to merge the initial structure.
Doing this, it's possible for other developers add more matchers and start using it.

@sksamuel

This comment has been minimized.

Copy link
Member

@sksamuel sksamuel commented Oct 22, 2019

sksamuel added a commit that referenced this issue Oct 22, 2019
* initial commit from jsoup assertions

* remove resource loader

* added some html matchers

* added some documentations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.