Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Json assertions to allow infix calls #1038

Merged
merged 1 commit into from Oct 7, 2019

Conversation

@Kerooker
Copy link
Member

commented Oct 5, 2019

No description provided.

@Kerooker Kerooker requested a review from sksamuel Oct 5, 2019
@Kerooker Kerooker force-pushed the feature/make-json-matchers-infix branch from fdce27d to 81fbba8 Oct 5, 2019
@EarthCitizen

This comment has been minimized.

Copy link
Member

commented Oct 5, 2019

Are matchJsonResource and containJsonKey supposed to be public?

@Kerooker

This comment has been minimized.

Copy link
Member Author

commented Oct 7, 2019

Yes, as one might want to use it with other matchers and such. The assertions are Unit, not matchers

@Kerooker Kerooker merged commit efdb611 into master Oct 7, 2019
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@Kerooker Kerooker deleted the feature/make-json-matchers-infix branch Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.