Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout config fails #879 Global timeout #858 #910

Merged
merged 3 commits into from Jul 21, 2019

Conversation

@sksamuel
Copy link
Member

commented Jul 20, 2019

No description provided.

@sksamuel sksamuel requested a review from Kerooker Jul 20, 2019

@Kerooker

This comment has been minimized.

Copy link
Member

commented Jul 20, 2019

Tests are failing.
We should fix them before the merge

@Kerooker

This comment has been minimized.

Copy link
Member

commented Jul 20, 2019

A weird assertion is failing tho

com.[secure].kotlintest.tables.TableTestingTest > assertions should be grouped in order STANDARD_OUT
The following 2 assertions failed:
1) Test failed for (name, sam) with error expected: "christian" but was: "sam"
at com.[secure].kotlintest.tables.TableTestingTest$11.invokeSuspend(TableTestingTest.kt:243)
2) Test failed for (name, billy) with error expected: "christian" but was: "billy"
at com.[secure].kotlintest.tables.TableTestingTest$11.invokeSuspend(TableTestingTest.kt:243)

@sksamuel

This comment has been minimized.

Copy link
Member Author

commented Jul 20, 2019

sksamuel added some commits Jul 20, 2019

@sksamuel sksamuel merged commit d04f05b into master Jul 21, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@sksamuel sksamuel added this to the 3.4 milestone Jul 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.